program: dynamic liquidation fee for liq_perp_with_fill #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispheaney
reviewed
Aug 15, 2024
| pub struct SetUserStatusToBeingLiquidated<'info> { | ||
| pub state: Box<Account<'info, State>>, | ||
| #[account(mut)] | ||
| pub user: AccountLoader<'info, User>, |
There was a problem hiding this comment.
might want to add a signer here as well, i think anchor client is probably just adding it by default on the client side
| @@ -969,13 +967,28 @@ pub fn liquidate_perp_with_fill( | |||
| )?; | |||
|
|
|||
| let existing_direction = user.perp_positions[position_index].get_direction(); | |||
| let max_liquidation_fee = | |||
There was a problem hiding this comment.
- should use safe_math
- should prob just call get_ref once and then drop it
could potentially also just make this a method on the perp market account?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.